Repository navigation
Handle GNSS fix times sent in Unix seconds - #244
Merged
Merged
Conversation
Some vehicles send dynamics.vehicle.gnss's time in Unix seconds. Those fell below the 2020 cutoff and were read as GPS-epoch milliseconds, giving fixes dated January 1980. Times below 10^11 are now taken as seconds before the GPS time check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some vehicles send the
dynamics.vehicle.gnssfixtimein Unix seconds (e.g.1794604023= 2026-11-13 21:07:03 UTC)._gnss_unix_msonly expected Unix ms or GPS-epoch ms, so a seconds value fell under the 2020 cutoff and was read as GPS ms, decoding to 1980-01-26.Impact in the integration: every once-a-minute GNSS fix looks older than the last trip-progress fix, so
gnssLocationis never updated after navigation ends and the device tracker stays at its last trip position (andgnssTimeStamp/gnssErrorcarry 1980 timestamps).Change
timecomment indynamics.proto(comment only; gencode unaffected).🤖 Generated with Claude Code