Spike static-liburing ring lifecycle - #15
Closed
bright2227 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This PR replaces #14 after renaming its head branch to follow the repository's
feature/naming convention. It is stacked on #13 and targetsagent/add-uringcore-skeleton. Review only commit467543c; after #13 merges, this PR can be retargeted tomain.What changed
_uringcore_liburing.Ringwith the same lifecycle API as the raw-syscall spikelibs/src/liburing.a, avoiding a runtimeliburing.sodependency for this moduleWhy
Phase 1 requires both viable ring-management routes to be spiked before selecting the production native core. This gives the raw-syscall and static-liburing routes the same API and test boundary so the next decision record can compare them directly.
Impact
The existing CFFI proactor remains active, so there is no user-facing event-loop behavior change.
Review has identified one blocking packaging issue that remains to be fixed: the published sdist omits
libs/src/liburing.aand the vendored inputs needed to build it. A clean build from that sdist currently fails at link time. The branch is therefore kept as a draft.The local CPython 3.12 x86-64 development builds measured 35,152 bytes for raw syscalls and 109,840 bytes for static liburing. Release-build measurements are still required.
Validation
/usr/bin/gcc -fsyntax-only -Wall -Wextra -Werror -I/usr/include/python3.12 -Ilibs/src/include src/uringcore_liburing.c.venv/bin/ruff check setup.py tests/unit/test_uringcore_liburing.py uringloop/_uringcore_liburing.pyi.venv/bin/ruff format --check setup.py tests/unit/test_uringcore_liburing.py uringloop/_uringcore_liburing.pyi.venv/bin/mdformat --check docs/phase1-static-liburing-spike.md.venv/bin/pytest tests/ -v— 33 passed from the prepared checkoutuv build --wheel --sdistldd uringloop/_uringcore_liburing.cpython-312-x86_64-linux-gnu.so— libc only; no liburing dependency