Repository navigation
fix: preserve PostgreSQL columns for partial execution timing - #581
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PostgreSQL uploads retain the expected columns when a snapshot or test result lacks a compile or execute timing stage. Each missing timestamp becomes SQL NULL, so partial or empty timing lists no longer produce malformed VALUES tuples.
Update type - breaking / non-breaking
What does this solve?
Fixes #573. Fixes #574.
The PostgreSQL regression covers complete, compile-only, execute-only, empty, unrelated and reversed timing lists for both upload paths, checking tuple arity and subsequent fields. It failed before the fix; the full integration build passed 50 nodes afterward, with zero errors and two no-ops. An independent rerun also passed.
Outstanding questions
Other warehouse execution was not repeated. The new regression is PostgreSQL-only; the adapter gating was checked for the other six adapter names.
What databases have you tested with?