Repository navigation
Fix Microsoft Fabric compatibility in core artifact models - #582
Open
pradeepsrikakolapu wants to merge 1 commit into
Open
pradeepsrikakolapu wants to merge 1 commit into
pradeepsrikakolapu wants to merge 1 commit into
Conversation
## Summary Include Fabric in the existing SQL Server branches for reserved column names, full-refresh predicates, and documentation persistence configuration. ## Prompting Intent The engineer requested pushing the prepared dbt_artifacts compatibility patch and opening an upstream pull request using pradeepsrikakolapu, without committing or pushing the separate dbt-fabric worktree. ## Linked Sources - Upstream baseline: brooklyn-data@16662c0 - Companion adapter: https://github.com/microsoft/dbt-fabric ## Rationale Adapter dispatch cannot override the package's hard-coded model branches, non-dispatched upload column lists, or project-level persist_docs configuration. Reuse the existing SQL Server behavior for Fabric rather than duplicate models. Keep other adapter branches and Snowflake-only model enablement unchanged. This patch depends on companion Fabric upload macros in dbt-fabric. Validated all 11 upload datasets and enabled core models against Fabric Warehouse using dbt Core 1.12.5 and dbt-adapters 1.24.5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c2be06a-4302-4528-88ae-d5d2cabb2b21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extend the package's existing SQL Server compatibility branches to Microsoft Fabric
Warehouse. This fixes package-level SQL and configuration that cannot be overridden
through adapter dispatch alone.
Update type - breaking / non-breaking
What does this solve?
Fabric uses
target.type == "fabric", so SQL Server-only conditions currentlyexclude it even where it needs the same SQL:
"database"and"schema"in upload columnlists and source, staging, dimension, and fact models.
dim_dbt__current_modelsfull-refresh calculations.operations are not supported by the adapter.
The changes add
fabricto existing SQL Server branches. Other adapter paths areunchanged, no dataset columns or column ordering change, and Snowflake-only
analytics models remain disabled.
Outstanding questions
This is the package-side companion to Fabric-specific upload macros being prepared
in microsoft/dbt-fabric. Those adapter
changes are not yet published. This PR alone does not provide standalone, complete
Fabric support with an older adapter.
The consuming project needs dispatch configured as follows, in addition to the
package's normal upload hook:
No automated Fabric CI target is introduced here. The live regression currently
lives in the companion adapter worktree; upstream SQLFluff lint and other
warehouse integration suites were not run locally.
What databases have you tested with?
Live validation used dbt Core 1.12.5, dbt-adapters 1.24.5, and the in-progress
dbt-fabric 1.12.0 adapter changes. The scenario passed against dbt_artifacts
2.11.1 with this exact patch applied:
The patch also applies cleanly to current upstream
mainat16662c0.