feat(operators): add GetBlockTime->MTP swap and int64_t narrowing - #59
Merged
Merged
Conversation
Add two mutation operators: - Bitcoin Core only: replace `GetBlockTime()` with `GetMedianTimePast()`. Both live on CBlockIndex and return int64_t, but MTP lags the header timestamp, so locktime/timeout checks that pick the wrong clock are only caught by tests around that boundary. - Generic: replace `int64_t` with `uint32_t`. Silently truncates values above 2^32 and turns negatives into large positives, so a mutant only dies when a test exercises the wide or signed range. Added to `common` and mirrored in the Bitcoin Core set, which keeps its own list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two mutation operators:
Bitcoin Core only: replace
GetBlockTime()withGetMedianTimePast(). Both live on CBlockIndex and return int64_t, but MTP lags the header timestamp, so locktime/timeout checks that pick the wrong clock are only caught by tests around that boundary.Generic: replace
int64_twithuint32_t. Silently truncates values above 2^32 and turns negatives into large positives, so a mutant only dies when a test exercises the wide or signed range. Added tocommonand mirrored in the Bitcoin Core set, which keeps its own list.