Make the perltidyrc finding logic match Perl::Critic, with caveat - #194
Open
teodesian wants to merge 2 commits into
Open
Make the perltidyrc finding logic match Perl::Critic, with caveat#194teodesian wants to merge 2 commits into
teodesian wants to merge 2 commits into
Conversation
Since we want a default perlcriticrc, this requires resolution along the same lines as Perl::Critic::Config. Also provide a plausible justification for providing default configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary shortcoming with how things are done currrently versus upsteam perlcritic is not considering .perlcriticrc in the CWD; this is a common practice to override organizational preferences for particular repositories with legacy concerns.
Since we want a default perlcriticrc, this requires resolution logic along the same lines as Perl::Critic::Config.
Also provide a plausible justification for providing default configuration.