fix(release): synchronize the notifier and tolerate npm propagation - #566
Conversation
|
ty-everett
left a comment
There was a problem hiding this comment.
Critical maintainer review of exact head 0cfaebe: no blocking findings.
Reviewed the full nine-file change and its operational boundary. The explicit nested notifier path cannot recursively rewrite unrelated examples or installed dependencies; the executable regression verifies that exclusion, third-party range preservation, dry-run/workspace-only behavior, patch bump and repeat-run idempotence. The final portable test fails against the old sync source. Node 24 matches the function's existing engine contract. Longer publication waits preserve exact-byte conflict rejection, lifecycle-script denial, protected npm approval and all scan/attestation gates; existing publication still uses its original immutable candidate.
All applicable exact-head checks are terminal and successful: CI 35820246831 includes the merge gate, both UHRP/notifier infrastructure lanes, build/lint/policy and docs; CodeQL 35820246830 passes with zero open PR alerts; zero-new-Sonar succeeds; hosted runtime contracts and conformance runner pass. Scope-based package/mutation skips are validated by the strict merge gate. No review threads exist. Required local health/lint/format/build/typecheck/audit/docs and notifier tests/audit pass.
No public package bytes change. The subsequent published-version PR must include the nested notifier's refreshed lock even if generated by the already-running older release workflow. Main acceptance remains required after merge.



Program and scope
The post-publication sync currently misses the separately deployed UHRP notifier, leaving its first-party SDK floor and npm lock behind the service image. Include that explicitly owned directory in manifest reconciliation and lock refresh, and align its deploy scripts with the already-declared Node 24 runtime. Do not recursively traverse unrelated nested projects.
Release run 35818166489 also demonstrated npm metadata propagation beyond the previous five-minute poll window: SDK 2.8.0 appeared just after verification timed out and its actual registry tarball matches the immutable candidate. Allow 41 polls at 15-second intervals and a 90-minute publication job. Exact-byte verification, immutable retry, protected approval, provenance, scans and permission boundaries remain required.
Impact
Verification
pnpm health:check,pnpm lint,pnpm format:check,pnpm build,pnpm typecheck,pnpm audit:security, andpnpm docs:build.bash -n.Security and dependencies
Release and operations