Skip to content

fix: align identity search tokens and phrases before publication - #625

Merged
ty-everett merged 2 commits into
mainfrom
codex/identity-release-parity
Sep 25, 2026
Merged

ty-everett merged 2 commits into
mainfrom
codex/identity-release-parity

Conversation

@ty-everett

@ty-everett ty-everett commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Program and scope

Follow-up to #617 before its SDK 2.8.7 / Wallet Toolbox 2.14.2 candidates are published. Ordinary identity searches must select the same public names at the wallet filter and BRC100 result validator. Complete words, ignored English stopwords, quoted phrases and excluded phrases now use the same rules in both layers. Named fields scan ordered literal tokens, preserving punctuation, case and line boundaries. Direct filtering rejects invalid requested values without coercion and ignores inherited attributes.

Coordination: BotBoard #622 recovered expired #623 under explicit maintainer authorization. Both reference-wallet repositories are outside this change. No server index, wire encoding, wallet data, authentication, signing, recovery or BRC39 contract changes. Language-specific stemming remains an explicit existing limitation; this is not a full MongoDB linguistic implementation.

Exact reviewed head: 576cb5e9be59d50cf1d91a2f4b97e84bb4c3adb0.

Impact

  • Public package source changed: SDK 2.8.7 and Toolbox core/client/mobile 2.14.2, retaining the same still-unpublished patch versions.
  • Security-sensitive result/query binding reviewed.
  • Documentation, existing changelogs and generated release notes updated.
  • No dependency, lockfile, export, public type or runtime-target change.

Verification

  • Local repository patch coverage: 99.55% (219/220 points) against main, target 90%.
  • Full workspace pnpm health:check, lint, format:check, build, typecheck, audit:security: pass.
  • Full SDK suite: 211 suites / 7,476 tests, including 133 result-validation tests; Toolbox identity suite: 42 tests. Includes 31 shared ordinary lookup cases, with explicit SDK/Toolbox parity assertions.
  • Local MongoDB 8.2.6, using the compiled overlay IdentityStorageManager: all 31 cases agree with both compiled client matchers. Synthetic local records; separate signed-evidence validation remains below.
  • Offline signed identity BEEF through direct permission manager, WalletClient and binary bridge: current and older supported clients retain their prior results. The 48 previously characterized SDK 2.8.1/2.8.2/2.8.6 client-validator failures remain separate; this host patch cannot rewrite already-shipped app code. Optional ContactSource characterization remains outside the corrected overlay path.
  • 48 completed/two-step createAction/accounting cases across SDK 2.4.0, 2.5.0, 2.7.1, 2.8.1, 2.8.2 and 2.8.7: wire bytes unchanged, service-charge authorization retained.
  • Eight real-key BRC29 acceptance/refund cases with Message Box Client 2.5.4: pass, mocked I/O and no live funds.
  • Four packed-package checks and browser platform contract passed. The enforcing mobile platform contract passed with reviewed versioned budgets, including composition, maps and Hermes compilation.
  • Complete diff self-reviewed for correctness, compatibility, dependency and operational impact.
  • Exact-head hosted merge gate, Sonar, CodeQL and required package/platform checks are terminal successful.

Artifact growth review

The portable token matcher and direct-filter guards increase Metro gzip by approximately 0.6% relative to the preceding unpublished candidate, without new dependencies or Node adapters. The mobile README records exact raw/gzip/Brotli measurements for Metro and Hermes. Budgets follow the shared policy: at least 10% headroom above the reviewed measurements, rounded up to 5,000 bytes. Composition, source-map, bytecode compilation and all six size dimensions remain enforced. This is a reviewed versioned budget change, not an exception or disabled gate.

Security and release

  • No new override, advisory dismissal, quality suppression or skipped test.
  • No publication from a workstation or this PR; the earlier release run was cancelled before npm publication.
  • No API/wire/data migration. Protected publication follows corrected main and exact-source verification.
  • Exact-head CodeQL has no new alert and the repository Sonar gate has zero new findings/unreviewed hotspots.
  • Review conversations resolved and hosted validation complete before merge.

Hosted completion: CI 36100201635, CodeQL 36100201697 and conformance 36100201618 succeeded on the exact head. Review-thread pagination is complete with no threads, and the PR CodeQL alert query returned zero open alerts.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.13793% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...wallet/wallet-toolbox/src/utility/identityUtils.ts 98.36% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@ty-everett ty-everett left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer self-review of exact head 576cb5e9be59d50cf1d91a2f4b97e84bb4c3adb0: reviewed the complete diff and rechecked query binding, token/phrase parity, own-field guards, captured SDK intrinsics, literal ordered matching, published artifacts and mobile composition growth. No remaining actionable finding. All required CI, Sonar, CodeQL and conformance checks succeeded; no open review threads or new CodeQL alerts. Local validation includes all 7,476 SDK tests, 42 Toolbox tests, 99.55% patch coverage and 31 ordinary lookups agreeing with actual MongoDB. Stemming remains explicitly documented as unsupported. This is a self-review, not a claimed independent approval. Integrating under the maintainer authorization recorded in BotBoard #622, then verifying main and the protected release candidate before publication.

@ty-everett
ty-everett marked this pull request as ready for review September 25, 2026 06:00
@ty-everett
ty-everett merged commit 029831e into main Sep 25, 2026
46 checks passed
@ty-everett
ty-everett deleted the codex/identity-release-parity branch September 25, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant