Repository navigation
fix: align identity search tokens and phrases before publication - #625
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ty-everett
left a comment
There was a problem hiding this comment.
Maintainer self-review of exact head 576cb5e9be59d50cf1d91a2f4b97e84bb4c3adb0: reviewed the complete diff and rechecked query binding, token/phrase parity, own-field guards, captured SDK intrinsics, literal ordered matching, published artifacts and mobile composition growth. No remaining actionable finding. All required CI, Sonar, CodeQL and conformance checks succeeded; no open review threads or new CodeQL alerts. Local validation includes all 7,476 SDK tests, 42 Toolbox tests, 99.55% patch coverage and 31 ordinary lookups agreeing with actual MongoDB. Stemming remains explicitly documented as unsupported. This is a self-review, not a claimed independent approval. Integrating under the maintainer authorization recorded in BotBoard #622, then verifying main and the protected release candidate before publication.



Program and scope
Follow-up to #617 before its SDK 2.8.7 / Wallet Toolbox 2.14.2 candidates are published. Ordinary identity searches must select the same public names at the wallet filter and BRC100 result validator. Complete words, ignored English stopwords, quoted phrases and excluded phrases now use the same rules in both layers. Named fields scan ordered literal tokens, preserving punctuation, case and line boundaries. Direct filtering rejects invalid requested values without coercion and ignores inherited attributes.
Coordination: BotBoard #622 recovered expired #623 under explicit maintainer authorization. Both reference-wallet repositories are outside this change. No server index, wire encoding, wallet data, authentication, signing, recovery or BRC39 contract changes. Language-specific stemming remains an explicit existing limitation; this is not a full MongoDB linguistic implementation.
Exact reviewed head:
576cb5e9be59d50cf1d91a2f4b97e84bb4c3adb0.Impact
Verification
pnpm health:check,lint,format:check,build,typecheck,audit:security: pass.Artifact growth review
The portable token matcher and direct-filter guards increase Metro gzip by approximately 0.6% relative to the preceding unpublished candidate, without new dependencies or Node adapters. The mobile README records exact raw/gzip/Brotli measurements for Metro and Hermes. Budgets follow the shared policy: at least 10% headroom above the reviewed measurements, rounded up to 5,000 bytes. Composition, source-map, bytecode compilation and all six size dimensions remain enforced. This is a reviewed versioned budget change, not an exception or disabled gate.
Security and release
Hosted completion: CI 36100201635, CodeQL 36100201697 and conformance 36100201618 succeeded on the exact head. Review-thread pagination is complete with no threads, and the PR CodeQL alert query returned zero open alerts.