Import the SDK by its post-rebrand crate name - #1
Merged
Conversation
This crate declares intentumdiff-plugin-sdk in Cargo.toml but imported intentdiff_plugin_sdk in code, so it has not compiled since the rebrand - failing on lib code, not just tests. The WIT module path (intentdiff::plugin::parser) and the WIT package id (intentdiff:plugin@1.0.0) are a wire CONTRACT and are deliberately unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This crate declares intentumdiff-plugin-sdk but pinned tag v0.1.0, where the SDK still declares name = intentdiff-plugin-sdk. Cargo resolves a git dependency by package name, so it failed with 'no matching package named intentumdiff-plugin-sdk' regardless of the imports. v0.0.2-beta.1 is the first SDK tag carrying the renamed crate. Paired with the import fix on this branch so the crate actually builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate has not compiled since the rebrand.
Cargo.tomldeclaresintentumdiff-plugin-sdk; the source importedintentdiff_plugin_sdk. The rename reached the manifest and never reached the code, and the SDK has no[lib] nameoverride, so there is no escape hatch:It failed on lib code, not just tests, so nothing here built. It stayed invisible because the green checks on this repo are CodeQL, not a build.
What is deliberately NOT changed
intentdiff::plugin::parser::intentdiff:plugin@1.0.0intentdiff_plugin_sdk::A blanket rename broke all 69 components once before with 637 misleading failures. This matches the word-bounded crate name only, and the script refuses to write a file whose WIT reference counts changed.
Verified in the monorepo:
cargo test --workspace-> 83 binaries, 554 passed, 0 failed.🤖 Generated with Claude Code