Skip to content

fix: post-sync patch for stable FakeTSVersion help baselines - #270

Merged
buke merged 1 commit into
mainfrom
fix/post-sync-help-baseline
Sep 5, 2026
Merged

fix: post-sync patch for stable FakeTSVersion help baselines#270
buke merged 1 commit into
mainfrom
fix/post-sync-help-baseline

Conversation

@buke

@buke buke commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Help baselines drift whenever the real TypeScript version string length changes (header padding uses the live version). Tests now pin TS_TEST_VERSION / FakeTSVersion via versionForDisplay, and accepted baselines match that fixed padding.
  • After sync-internal.sh copies upstream sources (which wipe local harness edits), scripts/post-sync.sh re-applies scripts/patches/0001-ts-test-version-stable-help-padding.patch and refreshes the version-sensitive show-help baselines.
  • Together with sync.yml skip-same-tag (ci(sync): skip when already on target TypeScript tag #269), this prevents daily no-op sync PRs and stops version-length baseline churn on real syncs.

Test plan

  • go test ./pkg/execute/tsctests/ -count=1 -run 'TestTscCommandline$/tsc/show_help' green after baseline accept
  • ./scripts/post-sync.sh succeeds twice (idempotent: patch already applied, baselines stable)
  • CI green on PR

Keep help header padding stable across TS version bumps by pinning
TS_TEST_VERSION in the harness and re-applying it after every sync.
@buke buke added the chore label Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.29%. Comparing base (02a3140) to head (e5ff8bb).

Files with missing lines Patch % Lines
pkg/execute/tsc/help.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   54.31%   54.29%   -0.02%     
==========================================
  Files         436      436              
  Lines      153791   153801      +10     
==========================================
- Hits        83526    83512      -14     
- Misses      64591    64613      +22     
- Partials     5674     5676       +2     
Flag Coverage Δ
unittests 54.29% <92.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@buke
buke merged commit d0cc1f5 into main Sep 5, 2026
3 checks passed
@buke
buke deleted the fix/post-sync-help-baseline branch September 5, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant