Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game: Monster Loves You!; executable: MonsterLovesYou.exe; thread: 1569836033309151402.
Round 1 (PR 27, 2609-ad9eee6) changed the original 181s live hang (median FPS 0, main thread 100%) into a 23s terminated run. At 265412.589 Wine reports NtCreateThreadEx Unsupported flags 0x66; at 265412.961 worker 0148 faults executing guest EIP F9992CFC while main thread 0144 continues. The worker start and argument appear truncated to 32 bits; no FEX-HANG samples were emitted. This is diagnostic startup failure, not evidence of a game-code fault.
Replace the native worker entry with a low-address x86 int 0x2e trampoline and ordinary WOW64 thread creation. The existing syscall bridge dispatches the sampler natively after flushing guest state and releasing the JIT lock, consumes the stdcall argument, then returns to the normal guest thread-exit path. Keep executable gating, 15s delay, 12 samples, suspend/resume pairing and mapping/output after resume. Add an entry marker to distinguish successful bridge entry from mere thread creation. No Proton major, architecture, graphics or game-file change.
Validation: diff check clean; reviewed int 0x2e dispatch, stdcall stack cleanup, WOW64 thread initialization and loader-lock release. Existing FEX fault logging does not sample a live spin. CI must compile both frontends. Device validation: no worker execute fault at a truncated native address; sampler-entered marker and 12 bounded FEX-HANG EIP samples, or an explicit target-unavailable status. This is diagnostic round 2, not a confirmed fix for the original hang.