Repository navigation
fix(core): follow the std::filesystem::path fsystem API - #60
Merged
Merged
Conversation
indep moved the fsystem API over to std::filesystem::path and dropped getDelimiter() and iterator::getName() along the way. stela already absorbed that, so raising the stela pin is what makes the break visible here. Joining paths by hand around an explicit delimiter is the part that no longer has an API to lean on. _interpManifest() now stores the entrypoint path exactly as the manifest wrote it and leaves the join to _addNewPod(), which is the only place that knows the pod directory. That removes the asymmetry where one half of the path was assembled at parse time and the other half at load time. srcSupply was binding a reference to path::operator string_type(). That survives on POSIX because the temporary's lifetime is extended, but string_type is wstring on Windows, so ask for the narrow form outright. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BjENpT4q5ebxNQ5gp951PD
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
indeprefactored thefsystemAPI to returnstd::filesystem::path(a3e8809→6d97d43), removingfsystem::getDelimiter()andfsystem::iterator::getName().stelaalready absorbed that change in5d0aed4, butbyeolwas still pinned to stela2073f33, so nothing downstream had moved yet.Raising the pin to stela
3d39295is what makes the break visible — it surfaces five compile errors, all inpodLoader.cpp.What changed
module/core/CMakeLists.txt— stela pin2073f33→3d39295, which brings in indep6d97d43.module/core/loader/pod/podLoader.cpp— the real work. Path joining used to go through an explicit delimiter, and that no longer has an API to lean on:_interpManifest()storedgetDelimiter() + pathinentrypoint::paths, prefixing a separator at parse time so that_addNewPod()could later concatenate it onto the pod directory. The path is now stored exactly as the manifest wrote it, and_addNewPod()does the join withoperator/. This removes the asymmetry where one half of the path was assembled at parse time and the other half at load time — only_addNewPod()knows the pod directory, so the join belongs there.e.getName() != MANIFEST_FILENAME→e->filename() != MANIFEST_FILENAME.e.getDir() + getDelimiter() + e.getName()is by definitione.get(), so that line collapses.getCurrentDir() + getDelimiter() + path→(cwd / path).module/core/worker/supply/srcSupply.cpp—const std::string& filePath = *e;was binding a reference to the result ofpath::operator string_type(). It compiles on POSIX because the temporary's lifetime is extended, butstring_typeisstd::wstringon Windows, so this would have failed the Windows CI job. Now asks fore->string()outright.This one did not appear in the error list — it is a latent break the pin bump would have exposed only on Windows.
Verification
Built through the real pin (no
FETCHCONTENT_SOURCE_DIRoverride), resolving stela3d39295→ indep6d97d43:Path assembly was checked for behavioural equivalence at runtime, not just at compile time.
podLoaderTest.testDefaultLoaderInitlogs:"pod/sys" + "/" + "./sys.pod"(before) andpath("pod/sys") / "./sys.pod"(after) produce the same string. The sys pod's native.soand its byeol wrapper both load, andadd(5, 3) == 8evaluates.clang-format-18clean. The added} // namespace byinsrcSupply.cppis the formatter's doing — the new comment pushes that namespace past clang-format's short-namespace threshold — not a hand edit.Deliberately left out
No test was added. The change is a migration to a renamed API with no behavioural delta, and the existing
podLoaderTestcoverage already exercises the path assembly end to end.🤖 Generated with Claude Code
https://claude.ai/code/session_01BjENpT4q5ebxNQ5gp951PD