Repository navigation
fix(doc): configure to fetch stela/indep sources before doxygen - #66
Merged
Merged
Conversation
The reference INPUT points at _deps/{stela,indep}_dep-src, which only CMake FetchContent creates at configure time. doc ran doxygen without configuring, so the clean publish-doc runner had neither directory and the stela/indep API pages stayed empty despite #63's path fix. doc() now configures once (skipping when _deps already exists) so the fetched sources are present.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #63, addressing the Codex review comment ("Populate fetched sources before generating reference docs").
Problem
#63 pointed the doxygen
INPUTat_deps/stela_dep-src/...and_deps/indep_dep-src/..., but those directories are created only byFetchContent_MakeAvailableduring CMake configure.builder.py doc(and thepublish-docCI job) runs doxygen on a clean tree without configuring or building, so on every documentation run both inputs are absent and the stela/indep API pages are still omitted — the exact regression #63 meant to fix.Fix
doc()now runs a CMake configure before doxygen when_depsis missing, reusing the existingFetchContentdeclarations (no duplicated repo/tag — a single configure resolves the transitive stela → indep fetch). It is skipped when_deps/{stela,indep}_dep-srcalready exist, so repeat/local runs stay fast.builder.pyis the only change; the CI job already invokesbuilder.py docand has cmake/flex/bison installed.Verification
On a clean tree (
_depsabsent), a configure now creates exactly the referenced inputs:🤖 Generated with Claude Code