Repository navigation
doc: fix commit message template to match the convention - #8
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0173PkNPTZf2uLFzoEzUuqVZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.gitmessage.txtdocumented a commit format this project does not use. It said:but this repository actually writes
type(scope): subject, which is what CONTRIBUTING.md specifies and what the commit history follows.A contributor who opens the template and follows it writes a malformed subject line, gets it caught in review, and has to amend and force-push. That is exactly what happened on launcher#10.
The file was byte-identical in
byeol,launcher,stelaandindep, so all four carried the same wrong instructions. This applies the same fix here.Changes
#<module>: <type>: <subject>#<type>(<scope>): <subject># Module is one of sub module like 'interp', 'seedling'# Scope is the module or area you touched, like 'core' or 'installer'.#test: interp: add new test case...#test(interp): add new test case...seedlingno longer exists, so the scope examples now name modules that do.The new paragraph says the subject line alone is usually enough and that long reasoning belongs in the PR description — the template previously said nothing about length.
The seven types are unchanged. Only the first line of the file is not a comment, so nothing here leaks into a commit message body.
Depends on
byeolang/byeol#61 updates
CONTRIBUTING.md, the source of truth, and should land first. This PR is text-identical to the template in that one.🤖 Generated with Claude Code
https://claude.ai/code/session_0173PkNPTZf2uLFzoEzUuqVZ