Fix AL-Go bootstrap and public repository builds - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI could not check the private AL-Go template, and the container hook crashed while reading npm credentials in this AL-only repository. Organization-wide signing settings also required credentials unavailable to this public repository.
Use Microsoft's public PTE template, remove the unused npm bootstrap, and disable app signing for this PTE. Keep the existing container setup and inherit the organization's self-hosted,AL-Go runner setting. Make existing AL method calls explicit for strict analysis and configure AL-Go to use the repository ruleset.
Validation:
Runner access was configured separately from this diff: beyondmaillog-windows permits only this repository and contains byndit-win-04. The other three runners remain in byndit-private-windows. Organization secrets were not changed. Releases promote CI artifacts and will therefore also be unsigned. The separate Update AL-Go System Files workflow still requires access to GhTokenWorkflow.