test(core): re-vendor bin16 width-boundary vectors (LAB-868) - #70
test(core): re-vendor bin16 width-boundary vectors (LAB-868)#7027Bslash6 wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughChangesThe tests now validate the shortest MessagePack binary marker for compressed payloads. Fixtures add a 300-byte Wire-format validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/wire_format_vectors.rs`:
- Around line 101-104: Update the vector coverage assertions around the
legacy/bin counts to build occurrence counts keyed by each entry’s derived_from
value, then require exactly one *_bin twin for every legacy vector and reject
duplicates or missing parents. Preserve the existing total checks, and
explicitly assert that both width_boundary_bin16 and width_boundary_bin16_bin
entries are present.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d089bc23-8d3a-4cd7-b765-485357a20022
📒 Files selected for processing (3)
tests/dual_decode.rstests/vectors/wire-format.jsontests/wire_format_vectors.rs
Equal legacy/bin totals admit duplicate twins and orphaned parents, and never pin the LAB-868 width-boundary pair by name. Key every *_bin vector by derived_from, require exactly one twin per legacy vector, and assert width_boundary_bin16 + width_boundary_bin16_bin explicitly. CodeRabbit-Resolved: wire_format_vectors.rs:101:Enforce one-to-one twin cover
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
@kody start-review |
Re-vendors the protocol wire-format 1.1.1 fixture after the new real-writer bin16 boundary pair landed.
LAB-868
Summary by CodeRabbit
Bug Fixes
bin8,bin16, orbin32).Tests