docs: update metrics performance note to reflect v2.11 improvement - #558
Open
gbenhaim wants to merge 1 commit into
Open
docs: update metrics performance note to reflect v2.11 improvement#558gbenhaim wants to merge 1 commit into
gbenhaim wants to merge 1 commit into
Conversation
The note about metrics reducing performance on busy servers was added when metrics were made opt-in in v2.6.0 (Sep 2022). Since then, #7492 moved instrumentation from per-handler to per-route, yielding ~5x faster collection with ~5.6x fewer allocations, and shipped in v2.11.1. Update the note to reflect the improvement and link to the PR, instead of the stale call-to-action. AI Disclosure: This commit was assisted by AI (Cursor with Claude). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
metricsglobal option documentation currently says:This warning was added when metrics were made opt-in in v2.6.0 (September 2022), based on #4644 which profiled the per-handler
metricsInstrumentedHandleras consuming up to 73% of request handling CPU time.Since then, #7492 moved instrumentation from per-handler to per-route collection, yielding ~5x faster metrics with ~5.6x fewer allocations. This fix shipped in v2.11.1 (February 2026).
This PR updates the note to reflect the improvement and link to the PR, replacing the now-stale call-to-action.
AI Disclosure
This PR was authored with assistance from AI tools (Cursor with Claude). All changes have been manually reviewed.
Made with Cursor