fix: keep the effect only when view belongs to a window - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Container setup can be lost while the view is detached from a window.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates iOS Liquid Glass effects to handle window lifecycle and deferred initialization.
Changes:
- Adds window-aware setup and teardown for
LiquidGlassView. - Defers container effect setup and disables initial animations.
- Adds runtime availability checks for glass APIs.
File summaries
| File | Summary |
|---|---|
ios/LiquidGlassView.swift |
Manages effect setup and cleanup across window transitions. |
ios/LiquidGlassContainerView.swift |
Defers container effect initialization; attachment retry handling remains required. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+19
to
+23
| guard needsInitialSetup else { | ||
| return | ||
| } | ||
|
|
||
| needsInitialSetup = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.