Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A vertical pager under a transparent navigation bar can shift its pages to the left and cover their content with a sideways blur/gradient on iOS 26. This reproduces with 9.0.4 in a sheet containing a navigation controller.
The vertical implementation rotates a horizontal
TabViewby 90 degrees. Rotation changes rendering but does not change the page's layout bounds, so the page can be centered in an inset frame in the wrong coordinate space. Native scroll edge effects also rotate with the underlying collection view.This change:
Related to #1099; this PR addresses the vertical layout case and does not claim to resolve every safe-area issue described there. No public API changes.
Test Plan
What's required for testing (prerequisites)?
An iOS 26 simulator/device and a native rebuild. Verification used Xcode 26.3, an iPhone 13 Pro simulator on iOS 26.2, and a small UIKit/SwiftUI harness using the library's actual
PagerView.swift, supporting Swift files, and SwiftUIIntrospect sources.What are the steps to reproduce (after prerequisites)?
Native reproduction results (pager bounds: 390 × 797 pt):
npm run typescript: passed.npm run lint: passed with 24 warnings in unchanged JavaScript/TypeScript files.npm test -- --runInBand --watchman=false: passed; the existing suite contains one TODO and does not cover native layout. The native harness above provides the regression verification.Each repeated
Page 1 / Row Nlabel below is a row within one full-size page, not a separate pager page.Screenshots
Reported application screenshots:
Compatibility
Checklist
README.md— not applicable; internal bug fix.