Repository navigation
chore: clean up native build config - #1172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-version native build and codegen changes warrant final human validation against all three supported React Native versions.
0 open findings
What changed in this PR
Modernizes native build and codegen configuration for supported React Native versions while tightening TypeScript module handling.
Changes:
- Simplifies Android Gradle and removes legacy Fabric registration.
- Updates iOS deployment targets and codegen metadata.
- Enables strict TypeScript module syntax and aligns scripts/documentation.
| File | Description |
|---|---|
tsconfig.json |
Enables no-emit and verbatim module syntax. |
src/utils.tsx |
Marks ReactNode as type-only. |
src/utils.ios.tsx |
Marks ReactNode as type-only. |
src/PagerView.tsx |
Marks native component types as type-only. |
README.md |
Documents supported React Native versions. |
react-native-pager-view.podspec |
Uses React Native’s minimum iOS version. |
package.json |
Updates packaging, scripts, and iOS codegen metadata. |
example/ios/Podfile.lock |
Refreshes native dependency checksums. |
CONTRIBUTING.md |
Documents the renamed typecheck command. |
android/src/main/java/com/reactnativepagerview/PagerViewViewManager.kt |
Removes legacy registration and modernizes event mappings. |
android/src/main/AndroidManifest.xml |
Simplifies the manifest. |
android/registration.cpp |
Removes legacy component registration. |
android/gradle.properties |
Removes superseded library defaults. |
android/build.gradle |
Reworks modern Android and Compose configuration. |
android/Android.mk |
Removes legacy NDK registration. |
.github/workflows/main.yml |
Uses the renamed typecheck command. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🟢 e2e: 14 passedAll 14 tests in 10 files
e2e 0.18.0 · 4m 6s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 6m 1s · ios · run artifacts |
troZee
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up the native build config
Android.mk,registration.cpp, theSoLoaderinit) and the unusedgradle.properties/debug.keystore.build.gradlenow follows thecreate-react-native-librarytemplate: defaults map,react-android, Java 17,compileSdk36, and namespace onlymin_ios_version_supported, andcodegenConfig.iosuses thecomponentsformattypecheckscript replacestypescript, andverbatimModuleSyntaxis on