Repository navigation
Re-land saved views as records on mdbase connect beta119 - #179
Merged
Merged
Conversation
beta119 stores hosted Obsidian Bases as records once setup adds base, so saved-view editing through the record operations works on hosted collections as well as local ones.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #176 (reverted in #177) on mdbase connect beta119, which is now in production.
#176 broke saved-view editing on hosted collections: Bases stayed hosted view resources after setup, so
read/updatefailed and new Bases weren't listed. mdbase-dev/mdbase-connect#514, shipped in beta119, fixes this:list_views/execute_viewinclude Base records.Its hosted-provider regression test runs TaskNotes' sequence against the real provider with the published
obsidian.basepack: setup,readwithinclude_documenton the converted Base, whole-documentupdate,create,list_views,execute_view.Checks:
pnpm verifypasses, including the manifest validated by the published beta119 devkit, 719 app tests, conformance and the build. The full Playwright suite passes (123 passed, 5 skipped).