Repository navigation
Keep wheel zoom inside the chart - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Chrome treats React's delegated wheel listener as passive. Planner's existing
preventDefault()therefore changed the chart zoom level but could not stop Chrome from magnifying the entire application at the same time.Impact
Ctrl/Cmd+wheel over the timeline now zooms only the Gantt chart. Normal vertical and horizontal wheel scrolling is unchanged.
Validation
pnpm typecheckpnpm lintpnpm test— 37 tests passedpnpm test:e2e— 2 Chromium tests passedpnpm build