Release Review: DedicatedNetworks r2.2 (rc Sync26) - #175
Release Review: DedicatedNetworks r2.2 (rc Sync26)#175camara-release-automation[bot] wants to merge 8 commits into
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 10 hints | Profile: standard |
tlohmar
left a comment
There was a problem hiding this comment.
All steps completed from our side
|
Not an approval and not a changes-requested review – attaching background information on this snapshot ahead of the Release Management review, so the pattern across review rounds is visible in one place (CHANGELOG entries against the Findings in details: One thing worth calling out here on its own, since it doesn't attach to any single issue: several of this round's Accesses fixes are correct on their own terms, but sit on top of the same three things underneath. An admitted device still has no resource identity of its own – no per-device read, no way to reference "that admission" in a later call. Separately: |
|
FYI: I have updated my restructuring proposal in #168 (comment) to include the accessGroup resource as container for device accesses, including the update of #169. That is still only a proposal showing how the open topics can be addressed, it does not say if and how it should land. One thing I would definitely not do: redefining the "access" resource from 0.1.0 into an access container for multiple device without choosing a new name for the newly introduced resource type. "accessGroup" is my proposal in #168, other names would work as well, just not "access" itself. |
|
Thanks for the very detailed review. Reading through the comments, I have two questions for clarification:
The current API design uses the Note, this restriction is because of the current use-cases in focus. Technically, using IP addresses could work similarly, with the restriction that the same IP address information as used during the initial add device operation (1) must also used during (2) and (3) step. Question: Currently, there are multiple CAMARA APIs, which use the
We are currently focusing on B2B use-cases, where the device (incl its subscription) is owned by the same organization, who is acting as API consumer on the Question: Does your comment mean that a sandbox API like |
I'm not aware of any API using the The device object is a subject identifier to be used to identify a device at resource creation time. It is not suitable to identify the created resource later unambiguous - you mentioned yourself the example with IP addresses which can change over time and not longer allow to identify the same device. Hence the need the created resource need an own resource identifier. Are you aware of any API which is using the device object as address for a created resource? Restricting now to
Yes, as an API is getting this capability for free if following the Design Guide. There is no need to restrict this by design, especially as v0.1.0 has already fulfilled this requirement. Also the introduction of the access(Groups) does not require to drop this requirement, as #169 shows. Refer also to the mandatory " # Authorization and authentication" section within the If the capability is utilized in a concrete use case "will be agreed upon during the onboarding process, happening between the API consumer and the API provider, taking into account the declared purpose for accessing the API, whilst also being subject to the prevailing legal framework dictated by local legislation.". The API design must not restrict this agreement without reason. |
tanjadegroot
left a comment
There was a problem hiding this comment.
The issues #176 and #165 identify that basic test scenarios are missing. Please be aware that main error codes test cases are considered basic (sunny day) scenarios for the API (I agree this is not explicitly documented in Commonalities and should probably be added there.)
The basic testcases should be provided with the release-candidate. I see 2 options:
- add the missing test case in r2.2 now (this rc.1)
- add the missing test cases in r2.3 which would be rc.2, and would also include applicable Commonalities r4.4 updates.
A second (very minor) comment is in the changelog file below.
All the rest looks OK.
Please let me know if you want to go for option 1 or 2.
| ### Breaking changes | ||
|
|
||
| * Support operations to manage access to dedicated network for multiple devices at a time | ||
| * by @hubertp-ericsson in https://github.com/camaraproject/DedicatedNetworks/pull/98 |
There was a problem hiding this comment.
Creating sub-bullets for the contributor name and issue ref makes the changelog different from all other changelogs, and slightly longer as well.
The request is to use a copy of the relevant provided lines in the working area list above. You can of course add more information in the bullet to help API consumers.
You can update or leave this as-is on this review PR now but I suggest to apply it in future releases.
There was a problem hiding this comment.
@tanjadegroot , thanks for the feedback.
A PR on the missing error cases (excl Accesses API) (#165) should become available tomorrow. The error cases for the accesses API depend on the yaml corrections, which require a bit more time (thus, a bit later).
A PR on the additional sunny day cases (#176) should also become available soon (also excluding additional Accesses API TCs).
Please advice, whether we should prio creation of an rc.1 pre-release or to prio addressing the issues. Both is fine.
I'll certainly update the CHANGELOG beforehand.
There was a problem hiding this comment.
@tlohmar : I would suggest prioritizing the addition of the above TCs (including the one for Accesses even if a bit later, over publishing the current rc.1. that is more important for the API and fllows the process. Quality over speed :-)
And thanks for adjusting the changelog !
As you will have to do a new snapshot, you can wait with that till then.
|
@hdamker , thanks for the elaborations. See my takes below
Ok, I understand, that we should / shall not use the
Ok, I understand that we should / shall support for 3-legged ATs (even for sandbox APIs), so that API providers can do a selection based on their needs. We'll prio focusing on use-cases, which require 3-legged ATs (i.e. B2B2C or B2C cases), in order to understand the needed functionality. |
|
FYI: This snapshot was created before camaraproject/tooling#431 got active with tooling release v0.10.0. #431 moved the automated README Release Information update from the release-review branch onto the snapshot branch. The merge commit above brings this branch in line with that: the README update now lives on the snapshot branch, so this branch differs from it by the CHANGELOG only. No content change. |
Addressing reviewer comments.
removing duplicated PR 102 listing
Areas Changelog: Merging Changed and Fixed into Added
Release Review: r2.2 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.2.0-rc.10.1.00.2.0-rc.10.1.00.2.0-rc.10.1.00.1.0-rc.1N/ADependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r2.2-6771f7f