Release Review: NumberVerification r4.1 (rc Sync26) - #244
Open
camara-release-automation[bot] wants to merge 3 commits into
Open
Release Review: NumberVerification r4.1 (rc Sync26)#244camara-release-automation[bot] wants to merge 3 commits into
camara-release-automation[bot] wants to merge 3 commits into
Conversation
camara-release-automation
Bot
requested review from
AxelNennker,
bigludo7 and
fernandopradocabrillo
as code owners
August 18, 2026 10:06
6 tasks
CAMARA Validation — PASS (with warnings)0 errors, 1 warnings, 0 hints | Profile: standard
|
Contributor
|
Hi team, please complete the code owner actions, thanks ! |
Contributor
|
Hi @AxelNennker & @bigludo7, I don't have permission to mark the boxes as “done,” but I'd say that, as far as TEF is concerned, there's nothing else to do here so as not to block the release management review (@tanjadegroot). WDYT? |
This was referenced Sep 4, 2026
hdamker
requested changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
I've reviewed the PR and content changes of this release. The two content findings are collected in #245:
- the reference of
Generic400has accidentally defined an additional error response code (OUT_OF_RANGE) which wasn't present in v2.1.0. As this addition would be breaking change and would need to be documented as such, I recommend to fix #247 on main before creating r4.1 - #246 is more cosmetic, but as this is a validation warning it must be documented as deferred or fixed. It is also easy to fix, a small inconsistency in applying the ref/bundling.
Three additional points regarding the release process - for the next snapshot after the fix:
- please do the codeowner actions timely and tick them off to avoid further delays in the release process ... please check also the validation results here on the Release Review PR ... the warning was not documented in an issue
- document the relevant changes from #235, especially the newly documented request-body strictness, and the PR #235 itself for information in the CHANGELOG
- The Design Guide RECOMMENDs a minor bump when an existing API adopts the request-body-strictness template ("Stable APIs (version ≥ v1.0): minor bump"). This release adopts it and ships as patch 2.1.1, which is worth a deliberate decision either way. It might be defensible, since
NumberVerificationRequestBodyalready hadmaxProperties: 1and therefore the behavior is unchanged for this API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Review: r4.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
2.1.1-rc.22.1.0Dependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r4.1-bb0c748