Skip to content

Release Review: SimSwap r4.1 (rc Sync26) - #283

Open
camara-release-automation[bot] wants to merge 12 commits into
release-snapshot/r4.1-7cf4786from
release-review/r4.1-7cf4786
Open

Release Review: SimSwap r4.1 (rc Sync26)#283
camara-release-automation[bot] wants to merge 12 commits into
release-snapshot/r4.1-7cf4786from
release-review/r4.1-7cf4786

Conversation

@camara-release-automation

@camara-release-automation camara-release-automation Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Release Review: r4.1 rc

This PR finalizes the reviewable release content for the active snapshot.

Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.

Release contents

API Version Status Comparison target
sim-swap-subscriptions 0.4.0-rc.1 rc 0.3.0
sim-swap 2.2.0-rc.3 rc 2.1.0

Dependencies: Commonalities r4.3, ICM r4.2

Codeowner Actions

Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.

  • Update the CHANGELOG

    What to do:

    • Copy all API-consumer-relevant changes from the provided list into the appropriate Breaking changes / Added / Changed / Fixed / Removed sections for each API. List breaking changes both in Breaking changes and in their normal change category.
    • Do not copy administrative, tooling-only, or internal maintenance changes unless they affect API consumers.
    • For each API, fill the CHANGELOG against the stated comparison target, following the release-type rules at the top of the CHANGELOG.
  • Document deferred validation warnings (and hints)

    What to do:

    • Check the CAMARA Validation comment on this PR for warnings and hints.
    • For each warning you do not fix, document it in an issue: include a copy of the validation summary line(s) and the reason the fix is deferred.
    • Document in the same way any validation hint that is applicable to the API and needs to be fixed later.
    • You may group several findings into one issue or split them across issues — either is fine.
    • List the documenting issue(s) in a comment on this PR.
    • Note: documenting deferred warnings is optional but recommended for alpha pre-releases, and mandatory for rc pre-releases and public releases.
  • The release is ready for Release Management review

    Check that:

    • All mandatory release assets for the declared status(es) are present (see the table below "Required release assets per API status" by expanding the arrow);
    • API documentation and test cases are adequate for the target status.

    Tick this box to confirm readiness and to start the Release Management review.

Release Management Actions

The following actions and checks are done by a Release Management reviewer before approving the PR:

  • Assign the Release Management reviewer(s) as assignee(s) of this PR
  • CHANGELOG follows the release documentation rules
  • Breaking changes are documented and version updates follow SemVer rules
  • Mandatory release assets are present for each API according to its status
  • All remaining validation warnings are documented in issues and the reasons for deferral are defensible
Required release assets per API status
Nr Asset alpha rc initial
public
stable
public
1 Release Plan M M M M
2 API Definition(s) M M M M
3 Commonalities compliance O M M M
4 API Documentation M M M M
5 User Stories O O O M
6 Test Cases (basic) O M M M
7 Test Cases (enhanced) O O O M
8 API Description O O M M

M = Mandatory, O = Optional — Full documentation

Valid next actions for codeowners

  • Merge this PR when all Codeowner Actions and Release Management Actions are complete and the required approvals are present — creates the draft release
  • Use /discard-snapshot <reason> in the Release Issue to discard this snapshot, return to planned, and update content on main

Snapshot: r4.1-7cf4786

@camara-validation

camara-validation Bot commented Sep 3, 2026

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

maxl2287
maxl2287 previously approved these changes Sep 3, 2026
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated

@albertoramosmonagas albertoramosmonagas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with these changes I think we can tick all the boxes for the review

Updated the changelog with recent changes and contributions.
@bigludo7

bigludo7 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Oups @albertoramosmonagas I did a mistake. I make same update but did not check that you have already done it. I do not know how I can remove my update. Could you please check if ok with these update and very sorry for the confusion.

Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
bigludo7
bigludo7 previously approved these changes Sep 3, 2026

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertoramosmonagas

Copy link
Copy Markdown

Hi, checks can be mark as solved from TEF's side

@maxl2287
maxl2287 self-requested a review September 3, 2026 12:11
maxl2287
maxl2287 previously approved these changes Sep 3, 2026
@hdamker hdamker self-assigned this Sep 3, 2026
@hdamker
hdamker dismissed bigludo7’s stale review September 3, 2026 17:52

Dismissing to avoid that this codeowner review will be taken as Release Management review by the ruleset.

Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated
Comment thread CHANGELOG/CHANGELOG-r4.md Outdated

@hdamker hdamker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Management review

Validation: PASS, nothing to defer.

CHANGELOG — suggestions inline on the diff:

  • sim-swap-subscriptions's Breaking changes, Added, Changed and Removed sections all read N/A, but the underlying diff is substantial: #272 bundled the API into the Commonalities r4.3 common schemas synced by #269 — new SubscriptionList response envelope, pagination, restructured notification events, Protocol/credentialType enum reductions. None of it is reflected.
  • sim-swap Breaking changes: N/A is correct for consumers, but monitoredPeriod is now bounded — a provider-facing compatibility risk lifecycle.md step 4 allows disclosing here for a stable minor.
  • I've attributed common-schema-migration entries to #272 rather than #269 — correct if you read the split differently.
  • EventSwappedData now requires phoneNumber (was optional) — intended, given this API's data-minimization language?

Asset gap: /retrieve-age-band (#273) has no test definitions (#289). Test Cases (basic) are mandatory at rc, and this isn't fixable on this branch. Can it land on main for a re-snapshot, or does it need a documented deferral?

Content findings not fixable here are filed as sub-issues of #284; none blocks this snapshot on its own.

@hdamker

hdamker commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@camaraproject/sim-swap_codeowners please see above review comment and the issues listed at #284. Independent if done for rc.1 or the next one there is significant work and some decisions to be done before Sync26!

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
bigludo7 and others added 6 commits September 4, 2026 13:51
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants