Release Review: SimSwap r4.1 (rc Sync26) - #283
Release Review: SimSwap r4.1 (rc Sync26)#283camara-release-automation[bot] wants to merge 12 commits into
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
Updated the changelog with recent changes and contributions.
|
Oups @albertoramosmonagas I did a mistake. I make same update but did not check that you have already done it. I do not know how I can remove my update. Could you please check if ok with these update and very sorry for the confusion. |
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
|
Hi, checks can be mark as solved from TEF's side |
Dismissing to avoid that this codeowner review will be taken as Release Management review by the ruleset.
hdamker
left a comment
There was a problem hiding this comment.
Release Management review
Validation: PASS, nothing to defer.
CHANGELOG — suggestions inline on the diff:
sim-swap-subscriptions'sBreaking changes,Added,ChangedandRemovedsections all readN/A, but the underlying diff is substantial: #272 bundled the API into the Commonalities r4.3 common schemas synced by #269 — newSubscriptionListresponse envelope, pagination, restructured notification events,Protocol/credentialTypeenum reductions. None of it is reflected.sim-swapBreaking changes: N/Ais correct for consumers, butmonitoredPeriodis now bounded — a provider-facing compatibility risk lifecycle.md step 4 allows disclosing here for a stable minor.- I've attributed common-schema-migration entries to #272 rather than #269 — correct if you read the split differently.
EventSwappedDatanow requiresphoneNumber(was optional) — intended, given this API's data-minimization language?
Asset gap: /retrieve-age-band (#273) has no test definitions (#289). Test Cases (basic) are mandatory at rc, and this isn't fixable on this branch. Can it land on main for a re-snapshot, or does it need a documented deferral?
Content findings not fixable here are filed as sub-issues of #284; none blocks this snapshot on its own.
|
@camaraproject/sim-swap_codeowners please see above review comment and the issues listed at #284. Independent if done for rc.1 or the next one there is significant work and some decisions to be done before Sync26! |
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Release Review: r4.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.4.0-rc.10.3.02.2.0-rc.32.1.0Dependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r4.1-7cf4786