fix: resolve r4.1 release review findings (#284) - #290
Draft
albertoramosmonagas wants to merge 1 commit into
Draft
fix: resolve r4.1 release review findings (#284)#290albertoramosmonagas wants to merge 1 commit into
albertoramosmonagas wants to merge 1 commit into
Conversation
Fixes camaraproject#284, camaraproject#285, camaraproject#286, camaraproject#287, camaraproject#289 - camaraproject#285: Clarify mandatory status of /check and /retrieve-date operations - Update info.description to specify optionality is limited to /retrieve-age-band - Add note that /retrieve-date latestSimChange is nullable for privacy reasons - Improve operation description wording - camaraproject#286: Update sim-swap-subscriptions description for v0.4.0 - Document pagination support (page/perPage, SubscriptionList) - Clarify mandatory event types field rationale - Fix garbled sentence about event types - Note HTTP protocol restriction - Document sink credential types (ACCESSTOKEN, PRIVATE_KEY_JWT) and notification event hierarchy - camaraproject#287: Fix documentation regressions - Restore broken RFC 3339 markdown link in sim-swap.yaml - Add example timestamp for latestSimChange property - Fix EventSwapped description from 'network type change' to 'SIM swap event' - camaraproject#289: Add test definitions for /retrieve-age-band operation - Create sim-swap-retrieveSimSwapAgeBand.feature with Gherkin scenarios - Cover age band values (1-17 and sentinel 111) - Test 2-legged and 3-legged access token variants - Include error cases (400, 401, 403, 404, 422, 501)
albertoramosmonagas
force-pushed
the
fix/r4.1-release-review-findings
branch
from
September 7, 2026 09:16
96056e5 to
a0c948f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284, #285, #286, #287, #289
What type of PR is this?
What this PR does / why we need it:
Comprehensive fix addressing all findings from the Release r4.1 review (#284). This PR resolves documentation regressions, clarifies API operation requirements, adds missing test definitions, and improves overall specification completeness and consistency.
Specific changes:
Special notes for reviewers:
SimSwapAgeBandschema can't express valid limits for the111sentinel (S-310/S-311 in #276) #277 (SimSwapAgeBand schema constraints) and Cross-API consistency issues between sim-swap and sim-swap-subscriptions #288 (cross-API consistency) remain open for follow-up as they require broader architectural decisions and group consensus (@KeldaAnders)Changelog input