Add performance modules - #36
Open
peaBerberian wants to merge 1 commit into
Open
peaBerberian wants to merge 1 commit into
peaBerberian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #35
This PR adds a few Performance metrics, by adding another performance-oriented event the
clientsends back to RxPaired.For now it polls those every 10 seconds. It might be too long, to check.
I focused on four kinds of metrics:
PerformanceObserverset tolongtaskfor when the UI thread (not the worker thread on which most of the RxPlayer might run) has poor performancePerformanceObserverset tolong-animation-framefor when an UI update took a lot of timePerformanceObserverset toeventfor when event handling was slowVideoPlaybackQualityreport mostly to know about dropped framesThe three
PerformanceObserver-based parts are useful to see numbers if the UI seems to have current performance issues on the tested device, what scale they are and where they're.The
VideoPlaybackQualityis more about the capacity of the device to reliably decode the current pushed quality without issue.I show both the last snapshot and the history in two different modules, here is what it looks like:
The sent message is also shown in the log window with the
Performancenamespace: