fix(lib): ContainsByteSlice never reports a match - #533
Open
devorun wants to merge 1 commit into
Open
Conversation
The helper used a naked return inside the match branch, so the named return value 'found' was never set to true. As a result the function always returned false even when the target was present in the list. Return true on a match and add table-driven tests covering presence at the head, middle, and tail, plus the empty-list and absent cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lib.ContainsByteSliceuses a nakedreturninside the match branch, so the named return valuefoundis never set totrue. The function therefore returnsfalseeven whentargetis present inlist:This helper fills a real gap because
slices.Containscannot operate on[][]byte([]byteis not comparable), so any current or future caller relying on it would silently get the wrong answer.Fix
Return
trueon a match.Tests
Added
TestContainsByteSlice(table-driven, matching the existing style inutil_test.go) covering the target present at the head, middle, and tail, plus the empty-list and absent cases. The presence cases fail against the previous implementation and pass with the fix.