feat: deploy builds to channels server-side and support multiple channels - #210
Closed
robingenz wants to merge 1 commit into
Closed
feat: deploy builds to channels server-side and support multiple channels#210robingenz wants to merge 1 commit into
robingenz wants to merge 1 commit into
Conversation
…nels Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the apps builds create command to support deploying builds to one or more channels server-side by sending appChannelNames at build creation time, eliminating the CLI’s previous client-side “wait then deploy-to-channel” flow and allowing --channel to be used with --detached.
Changes:
- Extend build creation DTO to include
appChannelNames. - Change
--channelto be repeatable/comma-separated, parse it into a list, and send it asappChannelNameswhen creating builds (web-only), while keeping--channelmutually exclusive with--destination. - Remove client-side channel deployment creation (still create deployments client-side for
--destination) and add tests for channel parsing/forwarding and updated--detachedvalidation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/app-build.ts | Adds appChannelNames?: string[] to the build creation DTO. |
| src/commands/apps/builds/create.ts | Parses multi-channel input, forwards appChannelNames, relaxes --detached vs --channel, and removes client-side channel deployment creation. |
| src/commands/apps/builds/create.test.ts | Adds coverage for appChannelNames forwarding, comma-splitting, and updated detached/destination validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Closed as not planned for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
apps builds create --channelis now repeatable and comma-separated, and is sent asappChannelNameson build creation — the server deploys to the channels once the build succeeds, instead of the CLI creating the deployment client-side after waiting.--detachedcan now be combined with--channel(the deploy no longer requires the CLI to wait); the conflict remains for--destination, which still deploys client-side.--channelis web-only and mutually exclusive with--destination.Requires capawesome-team/cloud-api-worker#793 (deploy the API first).
🤖 Generated with Claude Code