Fix: undefined buffer_snapshot move assignment - #335
Open
GagaLP wants to merge 1 commit into
Open
Conversation
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
GagaLP
force-pushed
the
fix/fence-move-assign
branch
from
July 14, 2026 13:18
ed0d82a to
bc65580
Compare
Contributor
|
Surprising that this went unnoticed so long. Can we get a regression test for it? (Ideally one that actually fails on Linux before the fix) |
Coverage Report for CI Build 29335953907Coverage increased (+0.009%) to 95.076%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem I came across while porting Celerity to Windows. The move assignment operator never returned
*this, which resulted in really weird bugs on Windows.