Extend cloud aws rds discovery

[rmorandell-pgum]

Community contributors

Description

Discovery mode is being expanded to include the instance type (instance, cluster), which is also used in the other modes. Currently, only instances are discovered.

Cluster must be queried in the AWS CLI using the “describe-db-clusters” command.

The returned JSON is slightly different and includes additional fields.

Attached is a JSON output for testing purposes, which has been anonymized.

The behavior remains the same as before, since "instance" is specified as the default.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

clusters-response.xml

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• I have provide data or shown output displaying the result of this code in the plugin area concerned.

---

Centreon team (internal PR)

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID

Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.

Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• In case of a new plugin, I have created the new packaging directory accordingly.
• I have implemented automated tests related to my commits.
  • Data used for automated tests are anonymized.
• I have reviewed all the help messages in all the .pm files I have modified.
  • All sentences begin with a capital letter.
  • All sentences end with a period.
  • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
• After having created the PR, I will make sure that all the tests provided in this PR have run and passed.