Skip to content

rbd/admin: Add trash purge schedule APIs - #1336

Merged
mergify[bot] merged 4 commits into
ceph:masterfrom
anoopcs9:add-rbd-trash-purge-schedule-apis
Sep 21, 2026
Merged

mergify[bot] merged 4 commits into
ceph:masterfrom
anoopcs9:add-rbd-trash-purge-schedule-apis

Conversation

@anoopcs9

@anoopcs9 anoopcs9 commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Add TrashPurgeScheduleAdmin type with Add, List, Remove and Status methods for managing Ceph rbd trash purge schedules. These functions mirror the existing MirrorSnashotScheduleAdmin API but operate at pool/namespace level (image level is not supported by Ceph for trash purge schedules).

fixes #517

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Sep 14, 2026
@anoopcs9
anoopcs9 force-pushed the add-rbd-trash-purge-schedule-apis branch from eb7f02e to fc1657b Compare September 14, 2026 11:06
phlogistonjohn
phlogistonjohn previously approved these changes Sep 17, 2026
@mergify

mergify Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

Comment thread rbd/admin/tpschedule_test.go Outdated
@anoopcs9
anoopcs9 force-pushed the add-rbd-trash-purge-schedule-apis branch from fc1657b to ac9ee2a Compare September 18, 2026 05:48
@mergify
mergify Bot dismissed phlogistonjohn’s stale review September 18, 2026 05:49

Pull request has been modified.

Comment thread rbd/admin/tpschedule_test.go Outdated
Comment thread rbd/admin/tpschedule_test.go Outdated
Comment thread rbd/admin/tpschedule.go Outdated
@anoopcs9
anoopcs9 force-pushed the add-rbd-trash-purge-schedule-apis branch from ac9ee2a to ff22fc5 Compare September 20, 2026 05:51
This was missed when a real regression was fixed with commit 80cd55a.

Signed-off-by: Anoop C S <anoopcs@disroot.org>
These are the functions that let one administrate the trash purge
schedules for pools and namespaces.

Signed-off-by: Anoop C S <anoopcs@disroot.org>
Exactly matching the pattern of mirror schedule tests.

Signed-off-by: Anoop C S <anoopcs@disroot.org>
Signed-off-by: Anoop C S <anoopcs@disroot.org>
@anoopcs9
anoopcs9 force-pushed the add-rbd-trash-purge-schedule-apis branch from ff22fc5 to 0fadcc3 Compare September 20, 2026 06:21

@idryomov idryomov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from the RBD perspective

@mergify mergify Bot added the queued label Sep 21, 2026
@mergify

mergify Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-09-21 14:35 UTC · Rule: default · triggered by rule automatic merge
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-09-21 14:35 UTC · at ff5ab8db81b404c53965cac605f67250423c5cb7 · rebase

This pull request spent 15 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify
mergify Bot merged commit ff5ab8d into ceph:master Sep 21, 2026
16 of 17 checks passed
@mergify mergify Bot removed the queued label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rbd/admin: add calls to manage trash purge schedules

3 participants