Conversation
added 2 commits
September 15, 2026 12:13
Move monkey patching to a separate module, so any teuthology module that is not related on multithreading can be imported without patching. When the monkey patching is needed the module should be imported from the top of cli tools so all necessary functioned patched correctly: import monkeythreading
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
kshtsk
requested review from
amathuria and
deepssin
and removed request for
a team
September 15, 2026 10:14
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
Contributor
Author
|
The failure iin integration test is unrelated the ansible error: only associated with ceph-cm-ansible. |
The github action integration/test check fails with error in ansible.
ERROR! [DEPRECATED]: community.postgresql.postgresql_set has been removed. Use community.postgresql.postgresql_alter_system instead. This feature was removed from community.postgresql in
version 5.0.0. Please update your playbooks.
The error appears to be in '/root/src/github.com_ceph_ceph-cm-ansible_main/roles/paddles/tasks/setup_db.yml': line 2, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
let's try to bound the postgresql on older version than latest 5.0.0
to avoid changes in ceph-cm-ansible for now.
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
Contributor
Author
|
@djgalloway @zmc does it makes sense to stick the postgresql collection to |
Contributor
Made more sense to update the role IMO: https://github.com/ceph/ceph-cm-ansible/pull/892/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of monkey patching in teuthology/init locking all modules for patching, let modules be able to work without monkey-patching, and only initiate patching from cli scripts just including teuthology.monkeythreading