Repository navigation
fix: serve the OGC landing page at the API root - #4
Merged
Merged
Conversation
Stop generating HomeController: its redirect from / to swagger-ui.html shadowed the landing page and ended in a 404, because Swagger UI is served under /api/. The Swagger UI tests now run with the servlet context path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /(served at/ogcapi/in the EOEPCA deployment) must return the OGC API landing page. TheHomeControllergenerated by openapi-generator redirects/toswagger-ui.html, so browser-style requests (no JSONAcceptheader) were redirected and ended in a 404: Swagger UI is served under/api/..openapi-generator-ignore: stop generatingHomeController.java.ApiApiDelegateImplIT,test-application.properties: the Swagger UI tests now set the servlet context path, and use the samespringdoc.swagger-ui.pathas the deployment.Test plan
./gradlew buildin a cleaneclipse-temurin:17-jdkcontainer: 279 tests, 0 failures; noHomeController.javaunderbuild/generatedvalidation.shcheck onhttp://<host>/ogcapi/returns 200, ande2e.shpasses