Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容 / Summary
Unreadable saved state, archiving active terminals, and stopping external control could discard session data or leave previously accepted commands authorized. Review also hid staged files before the first commit and rendered Git failures as empty results. This PR addresses those regressions and bounds the related remote-resource and refresh lifecycles.
Includes English source strings and Simplified Chinese translations, targeted regression coverage, and CI wiring. No persistence schema migration or architectural restructuring.
验证方式 / Testing
CI passed on
ff3e349: run 39224831139. The full Xcode build and all 431 XCTest tests passed (0 failures), along with the browser and native-logic script steps.The initial CI failure on
47c9bfcexposed a Grok default-argument function-reference mismatch. Fixed by invoking the reader inside a no-argument async closure. Reader declarations in the isolated quota tests now come directly from production source, preserving labels, parameter types and defaults; corrected fixtures reproduced the same compiler error before the fix and passed all 11 quota scenarios afterward.55 Node test entries/subtests passed, 0 failed, 0 skipped using the combined command below. This includes the 42 existing browser tests plus compiled production-source harnesses; it is not a full app XCTest count.
node --test scripts/test-web-remote-*.mjs scripts/test-git-review.mjs \ scripts/test-git-untracked.mjs scripts/test-persistence-recovery.mjs \ scripts/test-workspace-lifecycle.mjs scripts/test-control-lifecycle.mjs \ scripts/test-usage-refresh.mjs scripts/test-http-lifecycle.mjs \ scripts/test-web-file-admission.mjs node scripts/verify-dependency-lock.mjs git diff --check0ef1ee0220239b3776f433314515fd849025673f.截图或录屏 / Screenshots or recordings
No screenshots captured; full app UI validation was unavailable locally. Visible changes are the busy-archive confirmation and Review error messages.
关联议题 / Related issues
Follow-up to the already merged #130; covers the remaining audit findings.