[Server] Decode pagination cursor once in Registry - #37
Open
chr-hertel wants to merge 1 commit into
Open
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invalid cursor threw
InvalidCursorExceptioninpaginateResults()but was silently read as offset 0 incalculateNextCursor()— both decoding the same string in the samegetTools()call.The cursor is now decoded and validated once per list call in a new
decodeCursor()helper; bothpaginateResults()andcalculateNextCursor()receive the decoded offset. One validation policy: any malformed or out-of-bounds cursor throws.Regression tests cover invalid cursors (non-base64, non-numeric, negative, out of bounds) across all four list methods plus a valid two-page walk.
Closes #28
Confidence: 9/10 — behavior for valid cursors is unchanged (verified by full unit suite), and the strict policy was already the externally observable one since paginateResults ran first.