[Server] Freeze Builder after build() and drop hasCustomRegistry flag - #44
Open
chr-hertel wants to merge 1 commit into
Open
[Server] Freeze Builder after build() and drop hasCustomRegistry flag#44chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10 — the two internal fixes, not the decomposition.
assemble()memoises into$this->parts, but every setter stayed callable afterwards and silently changed nothing. Every setter/add method now throws aLogicException("Builder is frozen after build()...") once the configuration has been resolved. Repeatedbuild()/buildStateless()calls still share the one wiring.private RegistryInterface $registry;(uninitialised) plus the parallel$hasCustomRegistryflag collapsed into?RegistryInterface $registry = null.Full unit suite, php-cs-fixer and phpstan green.
Confidence: 9/10 — mechanical guard + one-field collapse, both covered by new tests and the existing 1534-test suite; only residual risk is exotic downstream code that mutated a builder after build() and relied on the silent no-op.