[Server] Align Protocol's exception-to-error mapping with StatelessProtocol - #49
Open
chr-hertel wants to merge 1 commit into
Open
[Server] Align Protocol's exception-to-error mapping with StatelessProtocol#49chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8.
The two protocol classes had drifted in how a handler exception becomes a JSON-RPC error:
StatelessProtocol::toErrorResult()mapsMissingRequiredClientCapabilityExceptionto-32021and echoes the SDK'sLogicExceptionguidance, whileProtocolcollapsed both into a generic-32603. The shared handlers (CallToolHandler,GetPromptHandler,ReadResourceHandler) rethrow the capability exception explicitly expecting-32021, so the handshake era was silently swallowing it.Protocol::handleRequest()now maps both the same way the modern era does — plain\LogicExceptionfrom user code stays generic. The PSR-14 event gap inStatelessProtocolis left for the fullHandlerDispatcherextraction.Confidence: 9/10 — small additive catch blocks mirroring existing StatelessProtocol behavior, pinned by three new tests; full unit suite, cs-fixer and phpstan green.