[Server] Fail loudly when a transport is used without Protocol::connect() - #52
Open
chr-hertel wants to merge 1 commit into
Open
[Server] Fail loudly when a transport is used without Protocol::connect()#52chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted slice from #9 (closed): fail loudly when a transport is used without Protocol::connect().
LogicExceptioninstead of silently returning[]/null/doing nothing when the protocol callbacks were never wired (message handling, outgoing messages, pending requests, response finder, fiber yield).handleSessionEnd()stays tolerant: it is a teardown notification also reached viaclose()on error paths, where throwing would mask the original failure.ManagesTransportCallbackstrait intoBaseTransportand droppedInMemoryTransport's redundantonMessage()override.Confidence: 9/10 — small, fully covered by new unit tests; whole unit suite, cs-fixer and PHPStan green.