GH-149: Apply the client-side filter on the legacy sorting/pagination read path - #150
Open
jtnelson wants to merge 2 commits into
Open
GH-149: Apply the client-side filter on the legacy sorting/pagination read path#150jtnelson wants to merge 2 commits into
jtnelson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149
Summary
On the legacy read path for Concourse servers without native sorting and pagination support (older than 0.10), any read that combined a client-side
Predicatefilter with anOrderor aPageignored the filter entirely, soload,loadAny,find, andfindAnyoverloads that accept a filter could return records the filter rejects. This change applies the filter on that path.Behavior
Orderor aPageis requested.Scope
GH149.