Skip to content

GH-149: Apply the client-side filter on the legacy sorting/pagination read path - #150

Open
jtnelson wants to merge 2 commits into
developfrom
feature/GH-149
Open

GH-149: Apply the client-side filter on the legacy sorting/pagination read path#150
jtnelson wants to merge 2 commits into
developfrom
feature/GH-149

Conversation

@jtnelson

@jtnelson jtnelson commented Aug 1, 2026

Copy link
Copy Markdown
Member

Closes #149

Summary

On the legacy read path for Concourse servers without native sorting and pagination support (older than 0.10), any read that combined a client-side Predicate filter with an Order or a Page ignored the filter entirely, so load, loadAny, find, and findAny overloads that accept a filter could return records the filter rejects. This change applies the filter on that path.

Behavior

  • The filter now applies to legacy-path results whenever an Order or a Page is requested.
  • Pagination operates over the universe of records that pass the filter, so a page is populated only from records the filter accepts. This matches the behavior on servers with native sorting and pagination support.
  • Servers with native sorting and pagination support are unaffected.

Scope

  • Only the legacy read path changes. Regression coverage lives in GH149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy read path drops the client-side filter when sorting or pagination is requested

1 participant