Resolve unique selections to null under a deny-all visibility Scope - #153
Open
jtnelson wants to merge 1 commit into
Open
Resolve unique selections to null under a deny-all visibility Scope#153jtnelson wants to merge 1 commit into
jtnelson wants to merge 1 commit into
Conversation
A findUnique query executed through an Audience whose visibility scope denies all access previously resolved to an empty Set, even though the caller expects a single Record or null. The empty Set produced a ClassCastException at the call site. A unique selection now resolves to null, matching the findUnique contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an Audience's visibility scope for a Record class denies all access, a unique query (the findUnique path) resolved to an empty Set. The caller of findUnique expects a single Record or null, so the empty Set produced a ClassCastException at the call site.
Behavior
Scope