Repository navigation
feat(apply)!: delete at once instead of moving to a trash - #90
Merged
Merged
Conversation
A trash on the same disk freed nothing until a purge 14 days later, so a cleanup reported space the machine did not have. apply now deletes for good, and the safety lives in what a plan may include plus a last check right before each deletion: no live process may work in or hold a file in the path, and no filesystem may be mounted inside it. undo, purge and --older-days are gone. The first apply or nightly run reports the size of any trash an older keeper kept, then deletes it. Every apply logs each deleted path and its bytes. purgeHook becomes deleteHook, run with the worktree's path before deletion; the action "trash" becomes "delete" and the scan schema version is 8. Closes #89 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying keeper with
|
| Latest commit: |
d1a3ef0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b0a53dd.keeper-9oy.pages.dev |
| Branch Preview URL: | https://cb-apply-deletes.keeper-9oy.pages.dev |
Accept the old purgeHook key, refuse plans from another version, empty old trash after the rescan with a holder check and per-transaction bytes, check holders before the delete hook, surface old trash errors in the exit code and wizard, and drop stale undo and purge from the patrol routines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Merged as d010b50. |
merge-loop Bot
pushed a commit
that referenced
this pull request
Nov 19, 2026
Prepares keeper 0.7.0: moves the Unreleased CHANGELOG entries under 0.7.0 and bumps package.json. 0.7.0 carries the breaking change from #90 (apply deletes at once; undo, purge and the trash are gone; purgeHook is now deleteHook). After merge, the merged main commit is tagged with `bun scripts/release.ts tag`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keeper applynow deletes at once. A trash on the same disk freed nothing until a purge 14 days later, so a cleanup reported space the machine did not have.What changed
applydeletes removals right away.undo,purge,--older-daysand the trash directory are gone.deletedin the audit log: each path and its bytes.autorun, reports the measured size of any trash an older keeper left (oldTrash) and then deletes it. Old transactions are deleted only after the same mount check and the delete hook, and a branch is dropped only if it has not moved.purgeHookis nowdeleteHook, run with the worktree path. A failing hook keeps the worktree.trashis nowdelete, andschemaVersionis 8, so cached findings are invalidated.Callers
Nothing calls
keeper purge. The timer runskeeper autodaily andkeeper samplehourly. The commented# purgeHookline in dotfilesconfig/keeper/config.tomlshould be renamed todeleteHookthere. The hook script only reads$1, so it still works.Verification
bun run gate:changedpasses: biome, tsc, 136 tests across the touched test files, and the changelog check.Review
Codex (gpt-reserve, xhigh) and Muse reviewed the diff independently; both findings lists overlapped heavily and neither failed. Fixed:
purgeHookconfig key is still read asdeleteHook, so an upgrade does not fail on an unknown key.applyexits 5 when old trash was kept, and the wizard reports old trash too.git worktree pruneis reported; a path that cannot be read is no longer treated as already gone.undoandpurgecalls in the patrol routines and the "cannot move whole" blocker text are updated.Not changed: a per-path process recheck for grouped findings (a process would have to start inside a later path within one apply), and deletion-ledger entries for transcript parent directories.
Closes #89
🤖 Generated with Claude Code