Skip to content

hotfix/cp-12240-getsubscriptionid-hangs-without-subscription - #369

Open
unnaticleverpush wants to merge 2 commits into
masterfrom
hotfix/cp-12240-getsubscriptionid-hangs-without-subscription
Open

hotfix/cp-12240-getsubscriptionid-hangs-without-subscription#369
unnaticleverpush wants to merge 2 commits into
masterfrom
hotfix/cp-12240-getsubscriptionid-hangs-without-subscription

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Prevent getSubscriptionId and CompletionFailureListener APIs from hanging indefinitely when autoRegister is false and the user never subscribes.


Summary by cubic

Fixes hangs when there’s no subscription by returning null or invoking failure callbacks instead of waiting forever. Addresses Linear CP-12240 when autoRegister is false and the user never subscribes.

  • Bug Fixes
    • CleverPush.getSubscriptionId(SubscribedListener) now calls the listener immediately with the current ID, queues only while initializing or subscribing, and returns null otherwise; setSubscriptionId notifies all queued listeners even when the value is null or empty.
    • All subscription-required APIs now fail fast with a clear error when there’s no subscription or the channel ID is missing: unsubscribe, stopCampaigns, add/remove/set topics, add/remove tags, remove attributes, tag tracking removal, set attributes, and mark/unmarkSubscriptionAsTest. Tag/attribute helpers also finish the operation after reporting failure.

Written for commit 4333757. Summary will update on new commits.

Review in cubic

Prevent getSubscriptionId and CompletionFailureListener APIs from hanging
indefinitely when autoRegister is false and the user never subscribes.
@unnaticleverpush unnaticleverpush self-assigned this Jul 30, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cleverpush/src/main/java/com/cleverpush/CleverPush.java
Comment thread cleverpush/src/main/java/com/cleverpush/CleverPush.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant