hotfix/cp-12240-getsubscriptionid-hangs-without-subscription - #369
Open
unnaticleverpush wants to merge 2 commits into
Open
hotfix/cp-12240-getsubscriptionid-hangs-without-subscription#369unnaticleverpush wants to merge 2 commits into
unnaticleverpush wants to merge 2 commits into
Conversation
Prevent getSubscriptionId and CompletionFailureListener APIs from hanging indefinitely when autoRegister is false and the user never subscribes.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent getSubscriptionId and CompletionFailureListener APIs from hanging indefinitely when autoRegister is false and the user never subscribes.
Summary by cubic
Fixes hangs when there’s no subscription by returning null or invoking failure callbacks instead of waiting forever. Addresses Linear CP-12240 when
autoRegisteris false and the user never subscribes.CleverPush.getSubscriptionId(SubscribedListener)now calls the listener immediately with the current ID, queues only while initializing or subscribing, and returnsnullotherwise;setSubscriptionIdnotifies all queued listeners even when the value isnullor empty.unsubscribe,stopCampaigns, add/remove/set topics, add/remove tags, remove attributes, tag tracking removal, set attributes, andmark/unmarkSubscriptionAsTest. Tag/attribute helpers also finish the operation after reporting failure.Written for commit 4333757. Summary will update on new commits.