chore: offload projects to nestjs - #2376
Conversation
shikanime
changed the title
|
🤖 Hey ! The security scan report for the current pull request is available here. |
87c5620 to
6ff0d1e
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
fe8ccc9 to
ee68675
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
20efae7 to
adee401
Compare
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2376.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
adee401 to
abdfd74
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Align keycloak and opencds feature-config schemas with the legacy env contract: the preview (ArgoCD) injects only legacy-required vars, so KEYCLOAK_CLIENT_ID/SECRET/ADMIN/ADMIN_PASSWORD/REDIRECT_URI and OPENCDS_URL/API_TOKEN are legitimately absent. Previously these were mandatory (z.string().min(1)/.url()), causing config parse to throw at bootstrap and the container to be marked unhealthy (502 on all nestjs routes). Default the optional vars to empty string and guard the opencds probeUrl transform against absent URLs so config parse no longer crashes boot. Fixes: unblocks PR #2376 UAT (issue #2379) Signed-off-by: shikanime <shikanime@users.noreply.github.com>
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
The deployment contract is nginx-strangler upstreaming server-nestjs:3001 over the container network. Defaulting SERVER_HOST to 'localhost' and SERVER_PORT to '0' made the app bind a random localhost-only port that the :3001 upstream could not reach, so the pod was marked unhealthy and every nestjs route returned 502. The .env.docker-example already sets these to 0.0.0.0/3001; make that the safe default so the preview is reachable even when the injected env omits them. Completes the startup-crash fix for PR #2376 (issue #2379). Signed-off-by: shikanime <shikanime@users.noreply.github.com>
|
🤖 Hey ! The security scan report for the current pull request is available here. |
39baf47 to
83ba753
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
648233d to
ced0dfe
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
519a74c to
b4b99ad
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
b4b99ad to
74559a0
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
02607b2 to
71a2fb9
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
2 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
There was a problem hiding this comment.
issue: Alors, j'aime bien l'idée de s'éviter une dépendance et de générer uniquement ce dont on a besoin (surtout pour contrôler des crons), mais il va falloir une palanquée de tests unitaires pour valider et maintenir tout ça 😉
14076fe to
53ca47e
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
dae1f5e to
aeeeaff
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I6f501bd1633ceb14edaa9bf2a324ea026a6a6964
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I3ebbec188732c0b9b3a9d088d2cca9e26a6a6964
|
2 New Issues
1 Fixed Issue
0 Accepted Issues2 participants
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Change-Id: I6f501bd1633ceb14edaa9bf2a324ea026a6a6964
Issues liées
Issues numéro: #2330 #2153
Quel est le comportement actuel ?
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
Autres informations