Repository navigation
Conversation
KastanDay
requested review from
a team,
craigsdennis,
ethulia,
kflansburg,
kodster28,
mchenco,
shridhar-cf and
superhighfives
as code owners
August 25, 2026 23:14
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33025 (https://github.com/cloudflare/cloudflare-docs/pull/33025).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-67b38c238025 · Request parameters duplicated in output schema
- **File:** `src/content/workers-ai-models/deepseek-v4-pro-0813.json` line 2414
- **Issue:** The added `reasoning_effort` and `chat_template_kwargs` blocks appear again at much deeper indentation around lines 2414-2436 and 3685-3707, which places them inside the output schema rather than under the two input variants.
- **Fix:** Remove `reasoning_effort` and `chat_template_kwargs` from the output schemas; they are request parameters and should only be documented under `schema.input` (Prompt and Messages).
### Suggestions (1)
#### CR-d4a0e3d5c2ed · Incomplete reasoning_effort mapping description
- **File:** `src/content/workers-ai-models/deepseek-v4-pro-0813.json` line 316
- **Issue:** The `reasoning_effort` enum includes `low`, but the description only documents mappings for `none`, `minimal`, `medium`, `auto`, and `xhigh`.
- **Fix:** Extend the description to state how `low` is handled (e.g. `low maps to low`) so every supported enum value is documented.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
Author
|
Superseded by #33541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #33022. Until that PR merges, GitHub includes its GLM-5.2 changes in this PR's diff. The layer-only comparison shows this PR's four-file change.
Why
Gemma 4 and DeepSeek V4 do not use the standard reasoning effort scale. Their model pages omit the accepted values and defaults, so users cannot tell which controls work or how compatibility aliases behave.
What changed
reasoning_effortvalues in the model schemas and Model Info cards.Logic diff: +21 / -0 lines
The count includes #33022 while both PRs target
production.Validation
pnpm checkpnpm lintpnpm format:checkpnpm build(8,902 pages)pnpm test(124 tests)