Add Connect 2026 homepage banner - #33562
Merged
Merged
Conversation
Contributor
|
Preview URL: https://1546bbd5.preview.developers.cloudflare.com |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://feat-connect-2026-banner.previews.developers.cloudflare.com (commit 1546bbd)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
MohamedH1998
marked this pull request as ready for review
September 22, 2026 09:36
Contributor
Review💡 3 suggestions found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33562 (https://github.com/cloudflare/cloudflare-docs/pull/33562).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (3)
#### CR-81e842f5ce4b · aria-label on role-less element
- **File:** `src/components/landing/Connect2026Banner.astro` line 56
- **Issue:** `aria-label="Featured speakers"` is set on a plain `<div>` (no role), so assistive technology will not expose the label — it has no effect for screen-reader users.
- **Fix:** Add `role="group"` to the element so the label is announced, or remove the aria-label if it is not needed.
#### CR-f33a61637ec6 · Keyboard-inaccessible tooltip content
- **File:** `src/components/landing/Connect2026Banner.astro` line 280
- **Issue:** The tooltip is appended to `<body>` by tippy, and the `focusout` handler on `speakerGroup` schedules `hideSpeaker()` whenever focus moves to anything outside the group — including the tooltip's own "Browse all speakers" link. Keyboard users can never tab into the interactive tooltip content before it closes (200 ms), and focus can briefly land on the soon-hidden link.
- **Fix:** Exempt focus moves into the tooltip popper from the close logic (e.g., check `speakerTooltip.popper.contains(event.relatedTarget)` in the focusout handler, or move the interactive link into the banner markup itself so it is natively focusable).
#### CR-d7f6dfc8098c · Duplicate SVG gradient IDs
- **File:** `src/components/landing/ConnectSpeakerLogo.astro` line 22
- **Issue:** The `<defs>` blocks hard-code global IDs (`connect-vite-primary`, `connect-vite-bolt` at lines 22/33, `connect-astro-accent` at line 104). This component takes a `name` prop and is meant to be rendered per speaker, so any page rendering the same speaker twice (or reusing the component elsewhere) emits duplicate IDs, and every `fill="url(#...)"` resolves to the first matching element in the document — invalid HTML with a real rendering risk if the first instance ends up inside a hidden/`display:none` container, where some browsers fail to paint the referenced gradient.
- **Fix:** Generate per-instance gradient IDs, e.g. derive them from `crypto.randomUUID()` (or a module-scoped counter) in the frontmatter and interpolate into both the `id` and the `fill="url(#...)"` references, so each rendered SVG references its own `<defs>`.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (3)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
diogoascarneiro
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a responsive, dismissible Connect 2026 banner below the homepage hero.
Validation
pnpm run checkpnpm run lintpnpm run format:core:checkpnpm run test(145 passed; Worker suites could not resolve the worktreedist/__redirectsasset)