Conversation
zkousama
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque and
scottbuscemi
as code owners
September 21, 2026 15:44
Contributor
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. Conventions❌ This review could not complete this run; results may be incomplete. It will retry on the next push. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
Review coverage🟡 1 ownership area needs approval. Suggested reviewers: @GregBrimble @irvinebroque
CODEOWNERS mappings for displayed areas (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_routes.jsonsection says wildcards match any number of path segments, and every example puts the wildcard at the end of a rule (/users/*,/build/*). A wildcard also works before a file extension, which the page doesn't say:/api/*.jsonexcludes every.jsonfile under/api/, at any depth.It's the rule a project needs when static files and Function routes share a path, like an API that serves pre-rendered
.jsonfiles beside routes a Function answers. With only trailing wildcards to go on, the rule that looks available is/api/*, and that sends every static file under/api/through the Function.This adds that case as a third example, and fixes a missing space in the wildcard note.
I checked the behaviour on a Pages project before documenting it, with
"include": ["/api/*"],"exclude": ["/api/*.json"]and a catch-all Function infunctions/api/[[path]].js:Documentation checklist