Skip to content

[R2 Data Catalog] Document deferred purge and deletion grace period - #33567

Open
agaddis02 wants to merge 1 commit into
cloudflare:productionfrom
agaddis02:adamtyler/IGLOO-320-delete-api-docs
Open

agaddis02 wants to merge 1 commit into
cloudflare:productionfrom
agaddis02:adamtyler/IGLOO-320-delete-api-docs

Conversation

@agaddis02

Copy link
Copy Markdown

Summary

Documents R2 Data Catalog deferred purge behavior and the deletion grace period property:

  • Clarifies that DROP TABLE ... PURGE defers physical file deletion by a configurable safety grace period (default 6 days / 518,400 seconds).
  • Documents the reserved property cloudflare-data-catalog.deletion.grace-period-seconds settable on tables and namespaces.
  • Adds Spark SQL and PyIceberg configuration examples.
  • Notes location reuse safety during the deferred purge window (new tables receive a unique storage prefix).

AI assisted with research and drafting.

Documentation checklist

@github-actions github-actions Bot added product:r2-data-catalog Related to R2 Data Catalog product size/s labels Sep 21, 2026
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning, 💡 1 suggestion found in commit 022e323.

👉 Fix in your agent 👈
Fix the following review findings in PR #33567 (https://github.com/cloudflare/cloudflare-docs/pull/33567).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-d5463b78bc6a · Incorrect PyIceberg API usage
- **File:** `src/content/docs/r2-data-catalog/deleting-data.mdx` line 128
- **Issue:** The PyIceberg `Transaction` yielded by `table.transaction()` has no `set_properties` method — `set_properties` is defined on `UpdateTableProperties`, returned by `transaction.update_properties()`. Running this example raises `AttributeError: 'Transaction' object has no attribute 'set_properties'`.
- **Fix:** Use `transaction.update_properties().set_properties({"cloudflare-data-catalog.deletion.grace-period-seconds": "86400"})`, or `table.update_properties().set_properties({...}).commit()` outside a transaction.

---

## Style Guide Review

### Suggestions (1)

#### SG-a1588fea9ec7 · Bullet list with fewer than three items
- **File:** `src/content/docs/r2-data-catalog/deleting-data.mdx` line 102
- **Issue:** Lines 102-103 form a two-item bullet list (Default grace period / Configuring the grace period).
- **Fix:** Consider writing these two points as prose instead of a bullet list.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
r2-data-catalog/deleting-data.mdx line 128 Incorrect PyIceberg API usage — The PyIceberg Transaction yielded by table.transaction() has no set_properties method — set_properties is defined on UpdateTableProperties, returned by transaction.update_properties(). Running this example raises AttributeError: 'Transaction' object has no attribute 'set_properties'. Fix: Use transaction.update_properties().set_properties({"cloudflare-data-catalog.deletion.grace-period-seconds": "86400"}), or table.update_properties().set_properties({...}).commit() outside a transaction.

Conventions

No convention issues found.

Style Guide Review

Suggestions (1)
File Issue
r2-data-catalog/deleting-data.mdx line 102 Bullet list with fewer than three items — Lines 102-103 form a two-item bullet list (Default grace period / Configuring the grace period). Fix: Consider writing these two points as prose instead of a bullet list.
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@cloudflare-docs-bot

Copy link
Copy Markdown
Contributor

Review coverage

🟡 1 ownership area needs approval.

Suggested reviewers: @Marcinthecloud @sejoker

Needs approval Eligible approvers Suggested
r2-data-catalog @jonesphillip, @laplab, @Marcinthecloud, @nagraham, @sejoker, @vovacf201, @cloudflare/product-owners marcinthecloud, sejoker
CODEOWNERS mappings for displayed areas (1)
Pattern Owners
/src/content/docs/r2-data-catalog/ @jonesphillip, @laplab, @Marcinthecloud, @nagraham, @sejoker, @vovacf201, @cloudflare/product-owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:r2-data-catalog Related to R2 Data Catalog product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant