Repository navigation
[Workers] Fix Preview URL jq path in Previews examples - #33641
Merged
yomna-shousha merged 2 commits intoSep 23, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
jahands
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne and
vy-ton
as code owners
September 23, 2026 22:14
Contributor
AI Review✅ Reviewed Commands
|
jahands
commented
Sep 23, 2026
| ``` | ||
|
|
||
| Use the JSON output to post the Preview URL to your review tool. | ||
| The output is a JSON object with `preview` and `deployment` keys. Read the Preview URL from `.preview.urls[0]` and post it to your review tool. |
Contributor
Author
There was a problem hiding this comment.
The changes to this line seem needlessly verbose - your'e just duplicating the example above (which agents will already be reading).
Contributor
Author
There was a problem hiding this comment.
From Cursor agent, not jahands:
Reverted this line to the original in d9338a7. The PR now only changes the jq filter in the GitHub Actions example.
Co-authored-by: Cursor <cursoragent@cursor.com>
yomna-shousha
approved these changes
Sep 23, 2026
yomna-shousha
enabled auto-merge (squash)
September 23, 2026 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrangler preview --jsonprintsJSON.stringify({ preview, deployment })to stdout (packages/deploy-helpers/src/preview/preview.ts#L1114-L1117, unchanged since cloudflare/workers-sdk#12983).PreviewResourcehasurls?: string[](api.ts#L68-L72), so the Preview URL is at.preview.urls[0].A top-level
preview_urlskey only exists in theWRANGLER_OUTPUT_FILE_PATHNDJSON entry (packages/wrangler/src/preview/preview.ts#L135-L145, cloudflare/workers-sdk#13197), never on stdout. The.preview_urls[0]branch in the GitHub Actions example (added in #31775) is dead code; the expression only works because jq's//falls through onnull.This PR simplifies the
jqfilter in the GitHub Actions example to.preview.urls[0].Documentation checklist