Skip to content

[Containers] Add direct API variants to container examples - #33681

Open
thomasgauvin wants to merge 2 commits into
codex/container-api-docsfrom
codex/pr-33093-examples
Open

thomasgauvin wants to merge 2 commits into
codex/container-api-docsfrom
codex/pr-33093-examples

Conversation

@thomasgauvin

Copy link
Copy Markdown
Contributor

Summary

Stacked on #33093. This PR changes only five example pages, adding Durable Object Container API variants next to the existing Container class examples: backend, cron, stateless routing, status hooks, and WebSockets. Review and merge #33093 first, then this PR.

Review feedback from #33093

Testing

The full local site build for #33093 rendered the changed routes, but failed on an unrelated missing GET /zones/{zone_identifier}/custom_pages/{identifier} operation in the local OpenAPI schema. Review CI before merging.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

AI Review

✅ Reviewed 93f6678 · 4 findings · incremental

👉 Fix in your agent 👈
Fix the following review findings in PR #33681 (https://github.com/cloudflare/cloudflare-docs/pull/33681).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification.
- If you disagree, explain why.
- If you need clarification before deciding, ask those questions.
- Then share your plan for which issues to tackle and in what order.

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit because the next review reads PR comments.

## Style Guide
- S-067080ad | src/content/docs/containers/examples/container-backend.mdx:148 | Port number not in monospace
  The style guide requires monospace for port numbers in prose. `8080` in "on port 8080" is a port number and appears without backticks, unlike the `GET /health` API command in the same sentence.
- S-15db821c | src/content/docs/containers/examples/stateless.mdx:17 | Port number not in monospace
  The style guide requires monospace for port numbers in prose. `8080` in "on port 8080" is a port number and appears without backticks.
- S-160ac5ec | src/content/docs/containers/examples/status-hooks.mdx:18 | Port number not in monospace
  The style guide requires monospace for port numbers in prose. `4000` in "on port 4000" is a port number and appears without backticks.
- S-12da131a | src/content/docs/containers/examples/websocket.mdx:17 | Port number not in monospace
  The style guide requires monospace for port numbers in prose. `8080` in "on port 8080" is a port number and appears without backticks.

Style Guide

  • src/content/docs/containers/examples/container-backend.mdx:148 · Port number not in monospace

    The style guide requires monospace for port numbers in prose. 8080 in "on port 8080" is a port number and appears without backticks, unlike the GET /health API command in the same sentence.

  • src/content/docs/containers/examples/stateless.mdx:17 · Port number not in monospace

    The style guide requires monospace for port numbers in prose. 8080 in "on port 8080" is a port number and appears without backticks.

  • src/content/docs/containers/examples/status-hooks.mdx:18 · Port number not in monospace

    The style guide requires monospace for port numbers in prose. 4000 in "on port 4000" is a port number and appears without backticks.

  • src/content/docs/containers/examples/websocket.mdx:17 · Port number not in monospace

    The style guide requires monospace for port numbers in prose. 8080 in "on port 8080" is a port number and appears without backticks.

Commands
  • /review Run a review now.
  • /full-review Review the entire PR diff.
  • /disable-auto-review Stop automatic reviews.
  • /rebase Rebase against production.

@cloudflare-docs-bot

Copy link
Copy Markdown
Contributor

Review coverage

🟡 1 ownership area needs approval.

Suggested reviewers: @mikenomitch @th0m

Needs approval Eligible approvers Suggested
containers @mikenomitch, @th0m, @cloudflare/cloudchamber, @cloudflare/product-owners mikenomitch, th0m
CODEOWNERS mappings for displayed areas (1)
Pattern Owners
/src/content/docs/containers/ @mikenomitch, @th0m, @cloudflare/cloudchamber, @cloudflare/product-owners

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://codex-pr-33093-examples.previews.developers.cloudflare.com (commit 93f6678)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a84eea34.previews.developers.cloudflare.com 93f6678 2026-09-25T03:05:58.422Z Visit the dashboard ↗
  • Build: Failed ❌

View logs ↗
6541c82 2026-09-25T01:59:20.597Z View logs ↗

@thomasgauvin
thomasgauvin force-pushed the codex/pr-33093-examples branch from 6541c82 to 93f6678 Compare September 25, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant